Skip to content

fix: Potential infinite loop in recursive splitting #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrwind-up-bird wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Potential infinite loop in recursive splitting #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions app/services/chunking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,12 @@ def chunk_text(
chunks.append(TextChunk(
index=len(chunks),
content=current.strip(),
char_count=len(current.strip()),
def _recursive_split(text: str, separators: list[str], chunk_size: int, depth: int = 0) -> list[str]:
# Prevent infinite recursion by limiting depth
if depth > 50:
# Force character-level split as fallback
return [text[i:i + chunk_size] for i in range(0, len(text), chunk_size)]

))

return chunks
Expand All @@ -125,7 +130,7 @@ def _recursive_split(text: str, separators: list[str], chunk_size: int) -> list[

parts = text.split(sep)

result: list[str] = []
result.extend(_recursive_split(part, remaining_seps, chunk_size, depth + 1))
for part in parts:
part = part.strip()
if not part:
Expand Down