featUpgrade cosmwasm by whalelephant · Pull Request #21 · nymlab/AVIDA

whalelephant · 2025-09-25T17:22:19Z

No description provided.

Copilot

Pull Request Overview

This PR upgrades CosmWasm from version 2.1 to 3.0, which introduces significant API changes and improvements. The upgrade includes updating all CosmWasm-related dependencies and adapting the codebase to use the new APIs, particularly around error handling and binary serialization functions.

Dependency version upgrades from CosmWasm 2.1 to 3.0 across all packages
Migration from deprecated functions to new CosmWasm 3.0 APIs (e.g., generic_err → msg, to_binary → to_json_binary)
Refactoring of error handling and verification result structures to improve type safety

Reviewed Changes

Copilot reviewed 33 out of 35 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`Cargo.toml`	Updates workspace dependencies to CosmWasm 3.0 and excludes specific contracts
`packages/cheqd/src/ibc.rs`	Replaces deprecated `StdError::generic_err` with `StdError::msg`
`packages/anoncreds/src/tests/types.rs`	Updates binary serialization functions to new CosmWasm 3.0 APIs
`contracts/sdjwt-verifier/src/verifier.rs`	Refactors verification handlers and result structures
`contracts/sdjwt-verifier/src/types.rs`	Changes `VerifyResult` structure from `Result` to separate success/error fields
`scripts/schemas.sh`	Updates schema generation command from `cargo run` to `cargo schema`

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-25T17:23:00Z

    )
 }

+/// Exec message handlers returns Response as data for verification


The comment is unclear and grammatically incorrect. It should be 'Exec message handler that returns Response with verification data' or 'Execute message handler that returns verification results as response data'.

Suggested change

/// Exec message handlers returns Response as data for verification

/// Execute message handler that returns verification results as response data

Copilot · 2025-09-25T17:23:00Z

+    Ok(Response::new().set_data(to_json_binary(&res)?))
+}
+
+/// Sudo message handlers returns error if verification fails


The comment is grammatically incorrect. It should be 'Sudo message handler that returns error if verification fails' or 'Sudo message handler - returns error if verification fails'.

Suggested change

/// Sudo message handlers returns error if verification fails

/// Sudo message handler that returns error if verification fails

Copilot

Pull Request Overview

Copilot reviewed 45 out of 52 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-26T06:36:52Z

    let keys = route_req.issuer_pubkeys.as_ref().map(|jwks| {
-        jwks.iter()
-            .map(|(_, jwk)| serde_json::to_string(jwk).unwrap())
+        jwks.values()
+            .map(|jwk| serde_json::to_string(jwk).unwrap())
            .collect()
    });


Using unwrap() on serde_json::to_string() can cause panics if serialization fails. Consider using proper error handling with ? operator or map_err() to convert to the appropriate error type.

Copilot · 2025-09-26T06:36:53Z

+                SdjwtVerifierError::SdjwtVerifierResultError(
+                    SdjwtVerifierResultError::VerifiedClaimsToBinaryError(e.to_string()),
+                )


The nested error wrapping SdjwtVerifierError::SdjwtVerifierResultError(SdjwtVerifierResultError::VerifiedClaimsToBinaryError(...)) creates an unnecessarily complex error chain. Consider using a direct error variant or flattening the error hierarchy.

Suggested change

SdjwtVerifierError::SdjwtVerifierResultError(

SdjwtVerifierResultError::VerifiedClaimsToBinaryError(e.to_string()),

)

SdjwtVerifierError::VerifiedClaimsToBinaryError(e.to_string())

Copilot · 2025-09-26T06:36:53Z

+    assert!(err
+        .to_string()
+        .contains(&SdjwtVerifierError::UnauthorisedCaller.to_string()));


The error assertion pattern using to_string().contains() is fragile and may break if error message formatting changes. Consider using pattern matching or direct error comparison for more robust tests.

Suggested change

assert!(err

.to_string()

.contains(&SdjwtVerifierError::UnauthorisedCaller.to_string()));

// Robustly check that the error is the expected contract error

let contract_err = err.root_cause().to_string();

assert!(

contract_err.contains("UnauthorisedCaller"),

"Expected UnauthorisedCaller error, got: {}",

contract_err

);

Copilot

Pull Request Overview

Copilot reviewed 46 out of 52 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-26T13:18:13Z

@@ -35,5 +35,5 @@ josekit = "0.8.6"
 sd-jwt-rs = "0.7.0"
 jsonwebtoken = { version="9.3.0", features=["use_pem"]}
 avida-test-utils = { path = "../../packages/avida_test_utils/", features = ["sdjwt"]}


This dependency references avida_test_utils which has been removed/renamed to avida_tests according to the changes in this PR. This will cause a build failure.

Suggested change

avida-test-utils = { path = "../../packages/avida_test_utils/", features = ["sdjwt"]}

avida_tests = { path = "../../packages/avida_tests/", features = ["sdjwt"]}

Copilot · 2025-09-26T13:18:13Z

+        jwks.values()
+            .map(|jwk| serde_json::to_string(jwk).unwrap())


Using unwrap() on serde_json::to_string() can cause panics. Consider using proper error handling instead of unwrapping, especially since this is in a query function that should return meaningful errors.

Copilot · 2025-09-26T13:18:14Z

+                serde_json::to_vec(&value)
+                    .map_err(|e| SdjwtVerifierError::VerifyResultError(e.to_string()))?,


This serialization is redundant since the value is already serialized JSON. Consider using to_json_binary(&value) directly or storing the binary representation differently to avoid double serialization.

whalelephant added 5 commits September 23, 2025 18:02

wip

b0ba49a

tests: remove downcast in tests

cc6d068

feat: update schema and serde_json

7ecac52

feat: upgrade cosmwasm with tests

e0ae37c

fix: Cargo.toml misspell

6c2de4c

whalelephant requested review from Copilot and lampkin-diet September 25, 2025 17:22

Copilot AI reviewed Sep 25, 2025

View reviewed changes

whalelephant and others added 8 commits September 25, 2025 18:39

fix: clippy

c002434

fix: compile and build by moving tests

cd7c312

chore: add toolchain

7f0cfcc

chore: add toolchain

d8064a9

feat: gha not override

05d1486

chore: fix gha

fd0e659

fix: try fix test error

67b8af5

Merge branch 'main' into upgrade-cosmwasm

2cbcb45

whalelephant requested a review from Copilot September 26, 2025 06:35

Copilot AI reviewed Sep 26, 2025

View reviewed changes

whalelephant added 3 commits September 26, 2025 10:48

fix: match versions

d3d0789

update optimizer

31b3611

fix: avoid wrapped err

c27c487

whalelephant requested a review from Copilot September 26, 2025 13:16

Copilot AI reviewed Sep 26, 2025

View reviewed changes

fix: redundunt ser

67f576c

whalelephant merged commit b49b5ce into main Sep 29, 2025
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

featUpgrade cosmwasm#21

featUpgrade cosmwasm#21
whalelephant merged 17 commits intomainfrom
upgrade-cosmwasm

whalelephant commented Sep 25, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 25, 2025

Uh oh!

Copilot AI Sep 25, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 26, 2025

Uh oh!

Copilot AI Sep 26, 2025

Uh oh!

Copilot AI Sep 26, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 26, 2025

Uh oh!

Copilot AI Sep 26, 2025

Uh oh!

Copilot AI Sep 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	/// Exec message handlers returns Response as data for verification
	/// Execute message handler that returns verification results as response data

	/// Sudo message handlers returns error if verification fails
	/// Sudo message handler that returns error if verification fails

-    assert!(err
-        .to_string()
-        .contains(&SdjwtVerifierError::UnauthorisedCaller.to_string()));
+    // Robustly check that the error is the expected contract error
+    let contract_err = err.root_cause().to_string();
+    assert!(
+        contract_err.contains("UnauthorisedCaller"),
+        "Expected UnauthorisedCaller error, got: {}",
+        contract_err
+    );

	avida-test-utils = { path = "../../packages/avida_test_utils/", features = ["sdjwt"]}
	avida_tests = { path = "../../packages/avida_tests/", features = ["sdjwt"]}

		jwks.values()
		.map(\|jwk\| serde_json::to_string(jwk).unwrap())

		serde_json::to_vec(&value)
		.map_err(\|e\| SdjwtVerifierError::VerifyResultError(e.to_string()))?,

Conversation

whalelephant commented Sep 25, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants