Conversation
whalelephant
left a comment
whalelephant
left a comment
There was a problem hiding this comment.
Thank you for this! some organisation comments for your feedback!
| IdxRevoked(u64), | ||
| } | ||
|
|
||
| impl std::fmt::Display for SdjwtVerifierResultError { |
There was a problem hiding this comment.
why impl and not just instead of using thiserror::Error?
packages/common/src/traits.rs
Outdated
There was a problem hiding this comment.
do we need this file? this is basically the expected ExecMsg right?
contracts/sdjwt-verifier/src/msg.rs
Outdated
|
|
||
| // Execute messages | ||
| #[cosmwasm_schema::cw_serde] | ||
| pub enum ExecuteMsg { |
There was a problem hiding this comment.
these can be moved to the package so to act as "interface".
Please look at https://github.com/CosmWasm/cw-plus/tree/main/packages/cw20 and how the packages are used in the contract implementations.
contracts/sdjwt-verifier/Cargo.toml
Outdated
| sd-jwt-rs = { workspace = true } | ||
| jsonwebtoken = { workspace = true } | ||
| serde_json = { workspace = true, default-features = false, features = ["alloc"]} | ||
| serde-json-wasm = {workspace = true} |
There was a problem hiding this comment.
I saw this
CosmWasm/cosmwasm#2195
looks like we can replace remove it?
|
|
||
| use crate::types::{PendingRoute, VerificationRequirements}; | ||
|
|
||
| pub const MAX_PRESENTATION_LENGTH: Item<usize> = Item::new("max_presentation_length"); |
There was a problem hiding this comment.
I would say some of these states can be moved to the package to be shared across verifier implementations.
For example, we have the typeVerfiablePresentation as Binary in the package because it will be required for any verifier, sd-jwt, anoncreds, zk, etc.
There was a problem hiding this comment.
Moved MAX_PRESENTATION_LENGTH to package, let's see what we can reuse after we develop other verifiers.
52c864a
2 participants
Closes #16