fix(schedule-editor): invalidate manifest cache after save [CUST-5442]#477
Merged
Conversation
Deleted custom fields (additional_fields) reappeared after saving because ManifestStore cached the pre-save manifest indefinitely. On re-mount the stale cache was served, and buildInternalProps fell through to it when the prop wasn't set by the parent. - Export invalidateManifestCache() from the manifest store - Call it after saveManifest() in the schedule editor - Also update the local manifest variable for in-session consistency Fixes CUST-5442
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
GitHub now auto-fails any workflow run that references the deprecated actions/cache@v2 (toolkit cache package shutdown). This failed the `build` job during job setup, before any code ran, which gated lint/type-check/test-unit (all skipped) and the Vercel deploys. Bumps all 8 actions/cache refs in build-test-publish.yaml to v4. No code changes; unblocks CI for this PR and the repo as a whole. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maithri471
approved these changes
Jun 17, 2026
AaronDDM
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Deleted custom fields (
additional_fields) in the Scheduler Editor reappear after saving and navigating away/back.Root Cause
ManifestStore(Svelte writable store backed by a Proxy) caches the scheduler manifest on first fetch and never invalidates the cache. WhensaveManifest()PUTs the updated config to the server, the client-side cache still holds the pre-save config. On the next component mount,onMountreads stale data from the cache andbuildInternalPropsfalls through to it — bringing deleted fields back.Fix
commons/src/store/manifest.ts— exportinvalidateManifestCache(componentId, accessToken)which deletes the cached entry so the Proxy's get-trap refetches on next access.components/schedule-editor/src/ScheduleEditor.svelte— aftersaveManifest()resolves:invalidateManifestCache()manifestvariable so in-session reads also reflect the saved statesaveProperties()async to properly await the saveTesting
Fixes CUST-5442