TW-5656: add dashboard domains management commands#109
Merged
Conversation
Add `nylas dashboard domains` for managing Nylas Inbox and Agent Account domains via dashboard-account: - list/check/create/show/dns/verify/update/delete subcommands - region inference for existing-domain commands (show/dns/verify/update/ delete) by listing domains when --region is omitted; create still requires --region - DashboardInboxDomain domain types, port methods, and AccountClient HTTP methods (GET/POST/PATCH/DELETE) with a shared doRaw helper - cursor-based pagination surfaced via --page-token / Next hints - DPoP htu now retains the query string to match the dashboard-account contract for query-bearing endpoints - setup wizard suggests registering a free Agent Account email domain Docs (COMMANDS.md) and unit/CLI tests included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
nylas dashboard domainsfor managing Nylas Inbox and Agent Account domains via dashboard-account.list/check/create/show/dns/verify/update/deletesubcommandsshow/dns/verify/update/delete): when--regionis omitted, the domain is resolved by listing domains and matching on ID or address.createstill requires--region.DashboardInboxDomaindomain types, port methods, andAccountClientHTTP methods (GET/POST/PATCH/DELETE) refactored behind a shareddoRawhelper.--page-tokenandNext:hints.htunow retains the query string to match the dashboard-account contract for query-bearing endpoints (documented deviation from RFC 9449 §4.2; pre-existing query-less endpoints unaffected).Testing
make cipasses (fmt, vet, lint, unit, race, security, vuln, build).Related docs