Skip to content

feat: add InternalModel for non-queryable models#345

Merged
nycomp merged 6 commits intoweeklyfrom
feat/internal-model
Feb 4, 2026
Merged

feat: add InternalModel for non-queryable models#345
nycomp merged 6 commits intoweeklyfrom
feat/internal-model

Conversation

@nycomp
Copy link
Contributor

@nycomp nycomp commented Feb 4, 2026

Summary

  • Adds InternalModel base class in campus.model.base for models that are used internally but not exposed through Campus API endpoints
  • Updates TableInterface to accept InternalModel | Model types
  • Updates PostgreSQL and SQLite backends to support InternalModel in init_from_model()

Related issue: #344

@nycomp
Copy link
Contributor Author

nycomp commented Feb 4, 2026

/home/runner/work/campus/campus/campus/api/resources/timetable.py
  /home/runner/work/campus/campus/campus/api/resources/timetable.py:15:48 - error: "Timetable" is not a known attribute of module "campus.model"

typecheck error is due to ongoing work in https://github.com/nyjc-computing/campus/tree/205-timetable-resource, not fixing in this PR

@nycomp nycomp merged commit cd362a3 into weekly Feb 4, 2026
3 of 4 checks passed
@ngjunsiang ngjunsiang mentioned this pull request Feb 4, 2026
@ngjunsiang ngjunsiang deleted the feat/internal-model branch February 5, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants