test: implement per-test isolation for integration tests#343
Merged
Conversation
Adds ServiceManager.reset_test_data() method for per-test isolation, resolving the test_00_* naming hack required for tests that expect empty state. Changes: - Add ServiceManager.reset_test_data() to reset storage between tests - Move reset from tearDownClass() to tearDown() in test_assignments.py - Re-create test tokens in setUp() after storage reset - Remove test_00_* prefix from test_list_assignments_empty Performance impact: Negligible (~0.04s increase for 12-test suite) - SQLite in-memory reset: just closes/reopens connection - MemoryCollection reset: just clears dict - Flask apps preserved (avoids blueprint re-registration issues) Fixes #335 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
Fix #335 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Option A variant (per-test reset) for issue #335, providing true test isolation while maintaining acceptable performance.
Changes
tests/fixtures/services.py: Added
ServiceManager.reset_test_data()methodtests/integration/api/test_assignments.py:
tearDownClass()totearDown()setUp()(required because reset clears credentials)test_00_*prefix fromtest_list_assignments_emptyTest Results
test_00_*prefixes remaining in codebasePerformance Impact
Minimal: ~0.04s increase for 12-test suite (0.25s → 0.29s)
reset_test_storage()is cheap (closes/reopens SQLite connection, clears dict)Usage Pattern for Other Tests
Trade-offs
setUp()test_00_*naming hackFixes #335
🤖 Generated with Claude Code