Skip to content

Add workaround for collection view problems with adding/removing last items in a section #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toto wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add workaround for collection view problems with adding/removing last items in a section #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions NXCollectionViewDataSource/NXCollectionViewDataSource/NXFetchedCollectionViewDataSource.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,9 +415,24 @@ - (void)controllerDidChangeContent:(NSFetchedResultsController *)controller
// ---------------

if (hasChanges) {

if (self.hasOffsetOrLimit) {


__block BOOL needsReload = self.hasOffsetOrLimit;
// WORKAROUND: Workaround a problem in the implementation difference of
// UICollectionView and NSFetchedResultsController
[self.deletedItems enumerateObjectsUsingBlock:^(NSIndexPath *indexPath, NSUInteger idx, BOOL *stop) {
if (indexPath.section < self.collectionView.numberOfSections) {
needsReload = ([self.collectionView numberOfItemsInSection:indexPath.section] == 1);
*stop = needsReload;
}
}];
[self.insertedItems enumerateObjectsUsingBlock:^(NSIndexPath *indexPath, NSUInteger idx, BOOL *stop) {
if (indexPath.section < self.collectionView.numberOfSections) {
needsReload = ([self.collectionView numberOfItemsInSection:indexPath.section] == 0);
Copy link
Collaborator

@anagromataf anagromataf Apr 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will never happen, as a fetched results controller will never return a section without an item.

*stop = needsReload;
}
}];

if (needsReload) {
// WORKAROUND: If the fetch offset or fetch limit is set, the collection view needs to reload,
// because the NSFetchedResultsController ignors this while handling the updates.

Expand Down