Undo #8 to revert introduced bug, fix #7 differently without breaking other formatting#10
Open
amterp wants to merge 4 commits into
Open
Undo #8 to revert introduced bug, fix #7 differently without breaking other formatting#10amterp wants to merge 4 commits into
amterp wants to merge 4 commits into
Conversation
This test should pass, but is failing, demonstrating the issue described in PR nwidger#9. A following commit will fix this test.
Consolidates some of the space-printing logic for fields, should be more consistent, and we can now correctly format JSON output, while fixing nwidger#7. With this commit, both tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See my comments on #9 . The fix in #8 doesn't work as intended and breaks formatting for the below case:
Broken (current master version):
{ "foo":"bar", << notice missing space "quz": [] << notice *correct* space }Fixed with this PR:
{ "foo": "bar", "quz": [] }I also include a couple of basic test cases demonstrating the fix to #7 and #9.
The individual commits in this PR contain some commentary and should probably not be squashed.