Complete 2nd nearest neighbor interactions implementation#10
Open
devin-ai-integration[bot] wants to merge 4 commits intomainfrom
Open
Complete 2nd nearest neighbor interactions implementation#10devin-ai-integration[bot] wants to merge 4 commits intomainfrom
devin-ai-integration[bot] wants to merge 4 commits intomainfrom
Conversation
- Fix TypeScript compilation errors in simulation script - Add j2j1ratio field to SimulationResultOnDisk type - Add frontend controls for j2j1ratio parameter - Update data loading and file naming for 3D parameter space - Enable full 3D parameter sweep (betaJ, betaH, j2j1ratio) The implementation extends the existing 2D parameter space to include second nearest neighbor coupling ratio (J₂/J₁). Users can now control this parameter via a slider in the web interface and see real-time updates to the lattice visualization and physical quantities. Co-Authored-By: asterisk37n@gmail.com <asterisk37n@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Remove legacy simulation data files that don't include j2j1ratio in filename. The new implementation expects all files to follow the pattern: betaj_X_betah_Y_j2j1_Z.json This fixes Vercel deployment which was failing because the code was trying to load files with the new naming convention but old files were still present with the legacy format. Co-Authored-By: asterisk37n@gmail.com <asterisk37n@gmail.com>
Include all generated simulation files with j2j1ratio parameter to support the complete 3D parameter space (betaJ, betaH, j2j1ratio) Co-Authored-By: asterisk37n@gmail.com <asterisk37n@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete 2nd nearest neighbor interactions implementation
Summary
This PR completes the implementation of second nearest neighbor interactions in the 3D Ising model simulation. The core physics simulation was already implemented in the WIP commit, but this PR resolves compilation errors and adds full frontend integration.
Key Changes:
j2j1ratiofield toSimulationResultOnDisktype to support the new parameterThe implementation extends the existing 2D parameter space to include the second nearest neighbor coupling ratio (J₂/J₁), allowing users to explore more complex magnetic interactions through the web interface.
Review & Testing Checklist for Human
Recommended Test Plan:
NEXT_PUBLIC_N=32 pnpm run simulateDiagram
%%{ init : { "theme" : "default" }}%% graph TD simulate["src/scripts/simulate.ts"]:::major-edit types["src/types.ts"]:::minor-edit configSection["src/components/config-section.tsx"]:::major-edit isingPage["src/components/ising-page.tsx"]:::major-edit pageApp["src/app/page.tsx"]:::major-edit metropolis["src/services/metropolis.ts"]:::context config["src/config.ts"]:::context simulate --> types simulate --> config metropolis --> simulate pageApp --> isingPage isingPage --> configSection pageApp --> types configSection --> config subgraph Legend L1["Major Edit"]:::major-edit L2["Minor Edit"]:::minor-edit L3["Context/No Edit"]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes