Conversation
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
WalkthroughAdds two release artifact manifest JSON files for 3.11.0 that enumerate Holoscan package versions, base/build container images (dgpu/igpu/cpu with device-specific keys), image references/tags, and health-probe download URLs; includes repeated historical entries for earlier releases. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
MMelQin
left a comment
There was a problem hiding this comment.
LGTM after having compared with previous releases and verifying the version value is correct.
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@releases/3.11.0/artifacts-cu12.json`:
- Around line 15-23: The dgpu and cpu image entries currently reference the
wrong suffix: update the "dgpu" and "cpu" object values that contain
"nvcr.io/nvidia/clara-holoscan/holoscan:v3.11.0-cuda12-igpu" to use the "-dgpu"
suffix instead (i.e., change "cuda12-igpu" to "cuda12-dgpu") so the "dgpu" and
"cpu" keys for version 3.11.0 point to the correct cuda12-dgpu images.
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Summary by CodeRabbit