Skip to content

fix: Ensure visual states are applied after OnApplyTemplate#57

Merged
jeanplevesque merged 1 commit intomainfrom
dev/jpl/fix-visual-states
Jun 6, 2025
Merged

fix: Ensure visual states are applied after OnApplyTemplate#57
jeanplevesque merged 1 commit intomainfrom
dev/jpl/fix-visual-states

Conversation

@jeanplevesque
Copy link
Member

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

What is the current behavior?

When a DataLoaderView gets its data while being inside a collapsed container, making the container visible afterwards doesn't refresh the visual states of the DataLoaderView, resulting in its content not being visible until the next change in visual states.

What is the new behavior?

The DataLoaderView refreshes its visual states when the OnApplyTemplate method is called.

Impact on version

  • Major (Public API was modified.)
    • Public constructs (class, struct, delegate, enum, etc.) were removed or renamed.
    • Public members were removed or renamed.
    • Public method signatures were changed or renamed.
  • Minor (Public API was extended.)
    • Public constructs, members, or overloads were added.
  • Patch (Public API was unchanged.)
    • A bug in behavior was fixed.
    • Documentation was changed.
  • None (The library is unchanged.)
    • Only code under the build folder was changed.
    • Only code under the .github folder was changed.

Checklist

Please check that your PR fulfills the following requirements:

  • Documentation has been added/updated.
  • Automated Unit / Integration tests for the changes have been added/updated.
  • Updated BREAKING_CHANGES.md (if you introduced a breaking change).
  • Your conventional commits are aligned with the Impact on version section.

Other information

…ts data before the control template is applied.
@jeanplevesque jeanplevesque requested a review from a team June 6, 2025 19:08
@jeanplevesque jeanplevesque merged commit ee48295 into main Jun 6, 2025
3 checks passed
@jeanplevesque jeanplevesque deleted the dev/jpl/fix-visual-states branch June 6, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants