Skip to content

Bug/allow rebuilds with scikit build #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robertmaynard wants to merge 2 commits into
base: branch-24.03
Choose a base branch
from
Open

Bug/allow rebuilds with scikit build #645

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1be0bcb
Only try to install python targets when not already found.
robertmaynard Mar 27, 2023
7e82207
When invoked from sk-build allow re-compilation
robertmaynard Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmake/legate_helper_functions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ function(legate_default_python_install target)
message(FATAL_ERROR "Need EXPORT name for legate_default_python_install")
endif()

if (SKBUILD)
if (SKBUILD AND NOT TARGET legate::${target}_python)
add_library(${target}_python INTERFACE)
add_library(legate::${target}_python ALIAS ${target}_python)
target_link_libraries(${target}_python INTERFACE legate::core legate::${target})
Expand All @@ -202,7 +202,7 @@ function(legate_default_python_install target)
endfunction()

function(legate_add_cpp_subdirectory dir)
set(options)
set(options ALWAYS_BUILD)
set(one_value_args EXPORT TARGET)
set(multi_value_args)
cmake_parse_arguments(
Expand Down Expand Up @@ -230,7 +230,7 @@ function(legate_add_cpp_subdirectory dir)
BUILD_EXPORT_SET ${LEGATE_OPT_EXPORT}
INSTALL_EXPORT_SET ${LEGATE_OPT_EXPORT})

if (SKBUILD)
if (SKBUILD AND NOT LEGATE_OPT_ALWAYS_BUILD)
if (NOT DEFINED ${target}_ROOT)
set(${target}_ROOT ${CMAKE_SOURCE_DIR}/build)
endif()
Expand Down