Skip to content

fix(types): allow Tabs items to have boolean value#6146

Open
KazimirPodolski wants to merge 1 commit intonuxt:v4from
KazimirPodolski:tabs-value-boolean
Open

fix(types): allow Tabs items to have boolean value#6146
KazimirPodolski wants to merge 1 commit intonuxt:v4from
KazimirPodolski:tabs-value-boolean

Conversation

@KazimirPodolski
Copy link
Contributor

On hold until Reka merges unovue/reka-ui#2485 (if it will).

🔗 Linked issue

None.

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Tabs effectively allow boolean values as it works in runtime, but prints warnings in the console from props validation. This change adds boolean to the value type, no runtime changes.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added the v4 #4488 label Mar 3, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1350d62 and 6d24c85.

📒 Files selected for processing (1)
  • src/runtime/components/Tabs.vue

📝 Walkthrough

Walkthrough

The TabsItem interface in src/runtime/components/Tabs.vue has been updated to expand the type of the value property. The type annotation was changed from string | number to string | number | boolean, allowing the value field to accept boolean values in addition to previously supported types. This is a public interface modification with no behavioral changes to the component logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: allowing boolean values in Tabs component item types.
Description check ✅ Passed The description explains the bug fix rationale: boolean values work at runtime but trigger prop validation warnings, which are resolved by updating the type definition.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 3, 2026

npm i https://pkg.pr.new/@nuxt/ui@6146

commit: 5111e09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants