Skip to content

docs: use loading prop together with custom leading slot#6123

Open
karladler wants to merge 3 commits intonuxt:v4from
karladler:patch-2
Open

docs: use loading prop together with custom leading slot#6123
karladler wants to merge 3 commits intonuxt:v4from
karladler:patch-2

Conversation

@karladler
Copy link
Contributor

@karladler karladler commented Mar 1, 2026

Add note about loading icon using together with custom leading-slot, since it must be implemented within the slot.

🔗 Linked issue

Docs select-menu#loading

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)

📚 Description

Using loading prop together with a custom leading-slot will not show anything if not explicitly implemented there.
This is unexpected and should be fixed, as quick solution we add that to the docs for now.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Add note about loading icon using together with custom leading-slot, since it must be implemented within the slot.
@karladler karladler requested a review from benjamincanac as a code owner March 1, 2026 17:22
@github-actions github-actions bot added the v4 #4488 label Mar 1, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: af287c86-90ac-4e7b-8ea8-29b91e987353

📥 Commits

Reviewing files that changed from the base of the PR and between f26855d and d522a74.

📒 Files selected for processing (1)
  • docs/content/docs/2.components/select-menu.md

📝 Walkthrough

Walkthrough

Added a short clarification to the select-menu documentation under the "Loading Icon" section: the loading icon is rendered inside the leading slot and will not appear if a custom leading slot is provided unless the custom slot includes the icon explicitly. No code or public API declarations were changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main change: documenting the interaction between the loading prop and custom leading slot in the select-menu component.
Description check ✅ Passed The description is fully related to the changeset, explaining why the documentation note was added and the specific behavior being documented.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/content/docs/2.components/select-menu.md`:
- Around line 666-668: Update the existing note block that begins with "::note"
which currently says "The loading icon is rendered within the `leading` slot.
Keep that in mind when using a custom leading slot." to a clearer warning:
explicitly state that if a consumer provides a custom `leading` slot the
component's built-in loading icon will not be displayed automatically and must
be rendered inside the custom slot if desired; reference the `leading` slot and
the loading icon so users know they must implement the loading indicator
themselves when overriding `leading`.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fcdb231 and 219a06f.

📒 Files selected for processing (1)
  • docs/content/docs/2.components/select-menu.md

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 1, 2026

npm i https://pkg.pr.new/@nuxt/ui@6123

commit: e9a11b2

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@benjamincanac benjamincanac added the documentation Improvements or additions to documentation label Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants