docs: use loading prop together with custom leading slot#6123
docs: use loading prop together with custom leading slot#6123
Conversation
Add note about loading icon using together with custom leading-slot, since it must be implemented within the slot.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded a short clarification to the select-menu documentation under the "Loading Icon" section: the loading icon is rendered inside the leading slot and will not appear if a custom leading slot is provided unless the custom slot includes the icon explicitly. No code or public API declarations were changed. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/content/docs/2.components/select-menu.md`:
- Around line 666-668: Update the existing note block that begins with "::note"
which currently says "The loading icon is rendered within the `leading` slot.
Keep that in mind when using a custom leading slot." to a clearer warning:
explicitly state that if a consumer provides a custom `leading` slot the
component's built-in loading icon will not be displayed automatically and must
be rendered inside the custom slot if desired; reference the `leading` slot and
the loading icon so users know they must implement the loading indicator
themselves when overriding `leading`.
commit: |
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Add note about loading icon using together with custom leading-slot, since it must be implemented within the slot.
🔗 Linked issue
Docs select-menu#loading
❓ Type of change
📚 Description
Using loading prop together with a custom leading-slot will not show anything if not explicitly implemented there.
This is unexpected and should be fixed, as quick solution we add that to the docs for now.
📝 Checklist