fix(module): Update path that playground extends from#1754
Open
marr wants to merge 1 commit intonuxt:modulefrom
Open
fix(module): Update path that playground extends from#1754marr wants to merge 1 commit intonuxt:modulefrom
marr wants to merge 1 commit intonuxt:modulefrom
Conversation
Member
|
I'd prefer to fix it so it works with npm too - I tested it and thought it worked - can you tell me what version of npm you're using? |
Author
|
❯ npm -v ❯ node -v |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Fixes #1305
❓ Type of change
📚 Description
Fixes the module starter template. The playground was trying to extend from a module that wasn't accessible in the package. I tested this with npm. Maybe pnpm "just works" but npm was failing as it was unable to find 'my-module'.