fix: prevent occuring of TagError: adsbygoogle.push() error: All ins elements in the DOM with class=adsbygoogle already have ads in them. (https://github.com/nuxt-modules/google-adsense/issues/179)#211
Open
DDianovMD wants to merge 1 commit intonuxt-modules:mainfrom
Conversation
…elements in the DOM with class=adsbygoogle already have ads in them. (nuxt-modules#179)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Issue #179
❓ Type of change
📚 Description
Added check to prevent calling
.push({})more then once onwindow.adsbygoogleobject. Described error in the linked issue is happening only when for some reason push method is called more than once.P.S. I'm not really familiar with Vue.js/Nuxt and for this reason unit test is not included in the PR. This fixed the problem for me in my NextJS project and I decided to contribute. I hope this fix the issue for you guys too.