Skip to content

Add space on Regex of html includes #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Beethoven wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add space on Regex of html includes #258

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d22801
Added new AMP-STORY tags
Beethoven Apr 19, 2021
26b1e78
Add space on Regex of html includes
Beethoven Apr 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/tags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,12 @@ function getTags (modifiers = {}) {
'amp-springboard-player': { version: '0.1' },
'amp-sticky-ad': { version: '1.0' },
'amp-story': { version: '1.0' },
'amp-story-360': { version: '0.1' },
'amp-story-auto-ads': { version: '0.1' },
'amp-story-auto-analytics': { version: '0.1' },
'amp-story-interactive': { version: '0.1' },
'amp-story-panning-media': { version: '0.1' },
'amp-story-player': { version: '0.1' },
'amp-subscriptions': { version: '0.1' },
'amp-subscriptions-google': { version: '0.1' },
'amp-timeago': { version: '0.1' },
Expand Down Expand Up @@ -140,7 +145,7 @@ function filterTag (html, tag, { isTemplate, regex }) {
if (regex) {
return html.search(regex) > -1
}
return html.includes(`<${tag}`)
return html.includes(`<${tag} `)
}

function generateScript (cdnBase, tag, { isTemplate, script, version }) {
Expand Down