Fix #4162: start notifiers in goroutine with retry to avoid BBolt lock contention#4163
Closed
Fix #4162: start notifiers in goroutine with retry to avoid BBolt lock contention#4163
Conversation
…k contention connectToKnownNodes() may already be syncing transactions from peers when notifier.Run() is called, holding the BBolt write lock and causing read lock timeouts. Run notifiers in a background goroutine that retries failed notifiers every 30 seconds until all have started successfully. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Coverage Impact ⬇️ Merging this pull request will decrease total coverage on Modified Files with Diff Coverage (1)
🛟 Help
|
Member
Author
|
We chose to solve it using #4170 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partial fix for #4162
connectToKnownNodes()triggers transaction syncing from peers, which holds the BBolt write locknotifier.Run()needs a read lock and times out, causingStart()to return an error and the node to shut downstartNotifiers) that retries any failed notifier every 30 seconds until all have started successfullyTest plan
TestNetwork_startNotifiers/ok_-_succeeds_on_first_try: notifier starts on the first attemptTestNetwork_startNotifiers/ok_-_retries_on_first_failure: notifier fails once, is retried, and succeeds🤖 Generated with Claude Code