Skip to content

fix: normalize path separators for Windows compatibility #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomaslaich wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

fix: normalize path separators for Windows compatibility #693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions format/glob.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package format

import (
"fmt"
"strings"

"github.com/gobwas/glob"
)
Expand All @@ -23,6 +24,8 @@ func compileGlobs(patterns []string) ([]glob.Glob, error) {
}

func pathMatches(path string, globs []glob.Glob) bool {
path = strings.ReplaceAll(path, "\\", "/")
Copy link
Copy Markdown
Author

@thomaslaich thomaslaich Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should i use filepath.ToSlash(path) instead?

Copy link
Copy Markdown
Member

@brianmcgee brianmcgee Apr 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think this is the better approach.


for idx := range globs {
if globs[idx].Match(path) {
return true
Expand Down