feat: implement system.autoUpgrade module for periodic upgrades#436
Draft
feat: implement system.autoUpgrade module for periodic upgrades#436
Conversation
commiterate
reviewed
Mar 26, 2026
| description = "System Manager Upgrade"; | ||
|
|
||
| restartIfChanged = false; | ||
| unitConfig.X-StopOnRemoval = false; |
Contributor
There was a problem hiding this comment.
X-StopOnRemoval isn't an actual systemd unit option. Rather it's a NixOS-specific lifecycle option.
At least from what I can tell, system-manager's systemd unit diffing is handled by system-manager-engine which would need to be updated to support the NixOS-specific lifecycle options.
In this case we need X-StopOnRemoval so the system-manager-upgrade unit execution doesn't kill itself mid-upgrade.
Member
Author
There was a problem hiding this comment.
Right we need to implement both extra flags. I am looking at this.
jfroche
added a commit
that referenced
this pull request
Mar 27, 2026
We parse the directive from the unit file text and skip restarting the service if X-RestartIfChanged=false is set required for #436
jfroche
added a commit
that referenced
this pull request
Mar 27, 2026
We parse the directive from the unit file text and skip restarting the service if X-RestartIfChanged=false is set required for #436
This was referenced Mar 30, 2026
jfroche
force-pushed
the
build-with-refresh
branch
from
5652319 to
70a5d11
Compare
Avoid passing multiple related parameters (flake_uri and refresh) separately to build functions.
jfroche
force-pushed
the
build-with-refresh
branch
from
f592f37 to
181a420
Compare
jfroche
force-pushed
the
build-with-refresh
branch
from
181a420 to
bb04f57
Compare
jfroche
added a commit
that referenced
this pull request
Apr 8, 2026
We parse the directive from the unit file text and skip restarting the service if X-RestartIfChanged=false is set required for #436
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #253