Skip to content

fix: add rel="noopener noreferrer" to all target="_blank" links in modal #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olgahaha merged 2 commits into from
Apr 16, 2026
Merged

fix: add rel="noopener noreferrer" to all target="_blank" links in modal #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a693be
Initial plan
Copilot Mar 17, 2026
7dfa140
fix: add rel=noopener noreferrer to all target=_blank links in modal.ts
Copilot Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/modal/modal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,7 @@ export class CaptureEyeModal extends LitElement {
class="link-text"
href=${this._asset?.showcaseLink ?? '#'}
target="_blank"
rel="noopener noreferrer"
>
${this._asset?.creator ?? ''}
</a>
Expand Down Expand Up @@ -367,6 +368,7 @@ export class CaptureEyeModal extends LitElement {
? html`<a
href=${`${Constant.url.profile}/${this.nid}`}
target="_blank"
rel="noopener noreferrer"
>${image}</a
>`
: html`<div class="shimmer-profile-img"></div>`}
Expand Down Expand Up @@ -414,6 +416,7 @@ export class CaptureEyeModal extends LitElement {
class="link-text"
href=${this._asset.explorerUrl}
target="_blank"
rel="noopener noreferrer"
>
<span class="value-text">${transactionText}</span>
</a>`
Expand All @@ -435,6 +438,7 @@ export class CaptureEyeModal extends LitElement {
class="link-text"
href=${Constant.url.explorer}
target="_blank"
rel="noopener noreferrer"
>
<span class="value-text"
>${Constant.text.numbersMainnet}</span
Expand Down Expand Up @@ -474,7 +478,7 @@ export class CaptureEyeModal extends LitElement {

<span class="field-text">${item.field}:</span>
${item.url
? html`<a class="link-text" href=${item.url} target="_blank"
? html`<a class="link-text" href=${item.url} target="_blank" rel="noopener noreferrer"
><span class="value-text">${item.value}</span></a
>`
: html`<span class="value-text">${item.value}</span>`}
Expand All @@ -501,12 +505,12 @@ export class CaptureEyeModal extends LitElement {
: Constant.text.viewMore;
return html`
<div class="section">
<a href=${actionButtonLink} target="_blank"
<a href=${actionButtonLink} target="_blank" rel="noopener noreferrer"
><button class="view-more-btn">${actionButtonText}</button></a
>
<div class="powered-by">
${this._assetLoaded
? html`<a href=${Constant.url.numbersWebsite} target="_blank"
? html`<a href=${Constant.url.numbersWebsite} target="_blank" rel="noopener noreferrer"
>Powered by Numbers Protocol</a
>`
: html`<div class="shimmer-text" style="height: auto;">&nbsp;</div>`}
Expand All @@ -533,6 +537,7 @@ export class CaptureEyeModal extends LitElement {
<a
href=${this.currentEngagementZone.link}
target="_blank"
rel="noopener noreferrer"
class="eng-link"
@click=${this.trackEngagement}
>
Expand Down
3 changes: 2 additions & 1 deletion src/test/modal_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ suite('capture-eye-modal', () => {
</div>
</div>
<div class="section">
<a href="https://asset.captureapp.xyz/" target="_blank"><button class="view-more-btn">View More</button></a>
<a href="https://asset.captureapp.xyz/" target="_blank" rel="noopener noreferrer"><button class="view-more-btn">View More</button></a>
<div class="powered-by">
<div
class="shimmer-text"
Expand All @@ -84,6 +84,7 @@ suite('capture-eye-modal', () => {
<a
class="eng-link"
href="https://captureapp.xyz"
rel="noopener noreferrer"
target="_blank"
>
<img
Expand Down
Loading