Skip to content

fix: Restore local cover URIs, secure category bottom sheet, and esca…#581

Merged
null2264 merged 4 commits intonull2264:masterfrom
lalalasupa0:fix-local-markdown-ui
Mar 29, 2026
Merged

fix: Restore local cover URIs, secure category bottom sheet, and esca…#581
null2264 merged 4 commits intonull2264:masterfrom
lalalasupa0:fix-local-markdown-ui

Conversation

@lalalasupa0
Copy link
Copy Markdown
Contributor

@lalalasupa0 lalalasupa0 commented Mar 15, 2026

Description

This PR cleans up a few minor regressions and formatting anomalies introduced in recent system changes:

  1. Local Source Cover Resolution: Reverted cover.filePath back to cover.uri.toString(). Bypassing the native URI generation broke standard file:// scheme attachments for Coil 3 on Primary Storage directories containing spaces, causing ENOENT silent failures. Reverting restores proper encoding compatibility across both Scoped and Primary directories.
  2. Category Sheet UI Dissipation: Emptied updateBottomButtons() translation math inside SetCategoriesSheet.kt. Relying on strict XML constraint limits (applied in a previous PR) anchors the action row securely; the dynamic translationY math was causing the Cancel/Move buttons to slide completely off-screen on devices with dense lists.
  3. Markdown Formatting Anomalies: Added dynamic text replacement in MangaHeaderHolder to convert < and > into &lt; and &gt;. This stops Markwon from interpreting E-Hentai tags or generic bracketed notes as malicious HTML nodes. Added a regex escape for leading hyphens (-/*) to prevent single dashes from being swallowed as empty lists. Finally, re-bound LinkMovementMethod to the summary view so Markwon-parsed URLs remain physically clickable.

Checklist

  • Tested manually
  • Code follows project style

Add a 👍 reaction to pull requests you find important.

@lalalasupa0 lalalasupa0 force-pushed the fix-local-markdown-ui branch from 48ca0af to ad8fd81 Compare March 25, 2026 17:09
@lalalasupa0
Copy link
Copy Markdown
Contributor Author

Hey @null2264, just wanted to gently bump this

The CI build check failed purely because this branch was spun off prior to your ci: Fix nightly release commit, so it unfortunately ran the old workflow configuration and threw the D8 OOM exception. Let me know if you'd like me to rebase this against your latest master to clear the CI check, or if the diff looks solid to merge as-is 👀

@null2264
Copy link
Copy Markdown
Owner

I'll review it tomorrow, I was migrating my stuff to a new phone, took longer than I thought. But at a glance it seems fine to me.

@null2264 null2264 merged commit 1645989 into null2264:master Mar 29, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants