Skip to content

Add argument to specify path to ROMs#65

Open
andrewrabert wants to merge 1 commit intonukeykt:masterfrom
andrewrabert:rom_path
Open

Add argument to specify path to ROMs#65
andrewrabert wants to merge 1 commit intonukeykt:masterfrom
andrewrabert:rom_path

Conversation

@andrewrabert
Copy link
Copy Markdown

Adds a new argument -d: to specify the directory to use for ROMs.

Comment thread src/mcu.cpp
printf(" -ab:<page_size>:[page_count] Set Audio Buffer size.\n");
printf(" -d:<rom_path> Set ROM directory.\n");
printf("\n");
printf(" -mk2 Use SC-55mk2 ROM set.\n");
Copy link
Copy Markdown
Contributor

@UnBeatWaterGH UnBeatWaterGH May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would maybe separate -d: from the others since directories aren't related to audio. Something like this:

...
-a:<device_number>             Set Audio Device index.
-ab:<page_size>:[page_count]   Set Audio Buffer size.

-d:<rom_path>                  Set ROM directory.

-mk2                           Use SC-55mk2 ROM set.
-st                            Use SC-55st ROM set.
...

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Changed & force pushed.

@Breiztiger
Copy link
Copy Markdown

Breiztiger commented Jun 26, 2024

or you can make directory with rom name and automatic choose the right one when you type --mk1, --jv880 , ...

@andrewrabert
Copy link
Copy Markdown
Author

andrewrabert commented Jun 30, 2024

or you can make directory with rom name and automatic choose the right one when you type --mk1, --jv880 , ...

Being able to specify the folder via an argument is useful on Linux where the application is usually installed to a location where only the root user has write access too.

Ex.

$ pacman -Qql nuked-sc55
/usr/
/usr/bin/
/usr/bin/nuked-sc55
/usr/share/
/usr/share/licenses/
/usr/share/licenses/nuked-sc55/
/usr/share/licenses/nuked-sc55/LICENSE
/usr/share/nuked-sc55/
/usr/share/nuked-sc55/back.data
$ ls -l /usr/share/nuked-sc55
total 4396
-rw-r--r-- 1 root root  794352 May  7 17:39 back.data
-rw-r--r-- 1 root root   32768 Apr 28 19:22 rom1.bin
-rw-r--r-- 1 root root  524288 Apr 28 19:22 rom2.bin
-rw-r--r-- 1 root root    4096 Apr 28 19:22 rom_sm.bin
-rw-r--r-- 1 root root 2097152 Apr 28 19:22 waverom1.bin
-rw-r--r-- 1 root root 1048576 Apr 28 19:22 waverom2.bin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants