Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/plugins/props/util/Prop.js
Original file line number Diff line number Diff line change
Expand Up @@ -215,19 +215,24 @@ let Self = class Prop {
parsedValue = this.spec.convert.call(element, parsedValue);
}

if (this.equals(parsedValue, oldValue)) {
return;
// Resolve the default lazily so equality and propchange.oldValue match the getter.
if (
oldValue === undefined &&
!this.spec.get &&
this.default !== undefined &&
typeof this.default !== "function"
) {
oldValue = this.get(element);
}

element.props[this.name] = parsedValue;

let change = {
element,
source,
value: parsedValue,
oldValue,
};

// Reflect before the equality check: an explicit equal-value write still updates the attribute.
if (source === "property") {
// Reflect to attribute?
if (this.toAttribute) {
Expand All @@ -254,6 +259,12 @@ let Self = class Prop {
});
}

if (this.equals(parsedValue, oldValue)) {
return;
}

element.props[this.name] = parsedValue;

this.changed(element, change);
}

Expand Down
20 changes: 17 additions & 3 deletions test/plugins/props/propchange.js
Original file line number Diff line number Diff line change
Expand Up @@ -132,11 +132,25 @@ export default {
{
name: "Assigning current default-resolved value is a no-op",
run () {
this.data.element.v = 42;
return this.data.events;
let { element, events } = this.data;
let before = events.length;
element.v = 42;
return events.length - before;
},
arg: { props: { v: { type: Number, default: 42 } } },
expect: [["v", 42]],
expect: 0,
},
{
name: "First write reports the resolved default as oldValue",
run () {
let { element } = this.data;
let oldValue;
element.addEventListener("propchange", e => (oldValue = e.detail.oldValue));
element.prop = "new";
return oldValue;
},
arg: { props: { prop: { default: "initial" } } },
expect: "initial",
},
{
name: "Three writes fire three propchange events in order, synchronously",
Expand Down