Skip to content

Fix several type annotation innacuracies #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MatthieuDartiailh wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix several type annotation innacuracies #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73b1d02
remove wrong type annotation for Member __init__
MatthieuDartiailh Dec 17, 2025
4434d4b
add annotation for coercer __init__
MatthieuDartiailh Dec 17, 2025
059f1a6
add annotation for CAtom __getstate__ and __setstate__
MatthieuDartiailh Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion atom/catom.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,14 @@ class Member(Generic[T, S]):
setattr_mode: Tuple[SetAttr, Any] = ...
validate_mode: Tuple[Validate, Any] = ...
getstate_mode: Tuple[GetState, Any] = ...
def __init__(self) -> None: ...
@overload
def __get__(self, instance: None, owner: Type[Atom]) -> Self: ...
@overload
def __get__(self, instance: Atom, owner: Type[Atom]) -> T: ...
def __set__(self, instance: Atom, value: S) -> None: ...
def __delete__(self, instance: Atom) -> None: ...
def __getstate__(self) -> Any: ...
def __setstate__(self, state: Any) -> None: ...
def tag(self, **kwargs: Any) -> Self: ...
def clone(self) -> Self: ...
def add_static_observer(
Expand Down
2 changes: 2 additions & 0 deletions atom/coerced.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,3 +186,5 @@ class Coerced(Member[T, S]):
factory: Callable[[], S],
coercer: Callable[[S], T | T1 | T2 | S],
) -> Coerced[T | T1 | T2, T | T1 | T2 | S]: ...
def __init__(self, kind, args=None, kwargs=None, *, factory=None, coercer=None):
...
Loading