Enforce codestyle using pre-commit and some related fixes #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickisos
commented
Mar 11, 2022
erickisos
commented
Mar 11, 2022
erickisos
commented
Mar 11, 2022
erickisos
commented
Mar 11, 2022
erickisos
commented
Mar 11, 2022
erickisos
commented
Mar 11, 2022
erickisos
commented
Mar 11, 2022
erickisos
commented
Mar 11, 2022
erickisos
commented
Mar 11, 2022
erickisos
commented
Mar 11, 2022
erickisos
commented
Mar 11, 2022
erickisos
commented
Mar 11, 2022
erickisos
commented
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is just an attempt to enforce some "good practices" into the code by using
pre-commit.I want to know if it makes sense as of now, or if you think that it would be great to have something even more opinionated (like black)
The main reason behind something like this is to help the contributors to write code without any extra worries about "how to format the code", and "which are the specific code-style for this project".
Status
READY
Relates to #188