Open
Conversation
sethrj
approved these changes
Feb 24, 2026
| #include "OpticalPropPDFastSimPAR_tool.fcl" | ||
|
|
||
| process_name: OpticalPropagationProducer | ||
| BEGIN_PROLOG |
There was a problem hiding this comment.
The title of this file is probably incorrect now since it's more of a module declaration than a job execution.
| auto const& ps = config().OpticalPropagationTool.get<fhicl::ParameterSet>(); | ||
| fOpticalPropagationTool = | ||
| std::unique_ptr<IOP>(art::make_tool<IOP>(config().OpticalPropagationTools())); | ||
| std::unique_ptr<phot::IOpticalPropagation>(art::make_tool<phot::IOpticalPropagation>(ps)); |
There was a problem hiding this comment.
I think you can restore the IOP; otherwise delete the type alias.
| VISHits: | ||
| // VISTiming: | ||
| // VUVHits: | ||
| // VISHits: |
There was a problem hiding this comment.
Instead of commenting these out could they be empty tables?
Suggested change
| // VISHits: | |
| VISHits: {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates/fixes fcl files used by the
OpticalPropagationmodule. The original fcl file is now split into two:OpticalPropagationin more complex workflows