Move non-persistent settings to file in cache directory#167
Open
sotpapathe wants to merge 1 commit intonthdimtech:masterfrom
Open
Move non-persistent settings to file in cache directory#167sotpapathe wants to merge 1 commit intonthdimtech:masterfrom
sotpapathe wants to merge 1 commit intonthdimtech:masterfrom
Conversation
lastRemoveableBackup, lastUpdatePrompt, and windowGeometry are more like cached variables than proper settings since they may change at each start of the program. Moved them to a separate struct, localCache and split the saveSettings() and loadSettings() functions into two, one for localSettings and one for localCache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lastRemoveableBackup,lastUpdatePrompt, andwindowGeometryare more likecached variables than proper settings since they may change at each
start of the program.
Moved them to a separate struct,
localCacheand split thesaveSettings()and
loadSettings()functions into two, one forlocalSettingsand one forlocalCache.My motivation for this is due to the fact that I manage my dotfiles using git. Every time I start signet, one or more of the 3 options I move has changed so I see the file as changed but it makes no sense to commit it.