Warnings

[lundacode]

Hi,

I have three simple, low impact fixes:

1. fix a bad .png
2. get rid of most compiler warnings
3. discriminate between different firmware errors

What exactly "Target firmware version" is for?
I get that "Device firmware version" is the actual FW version read out from the device, say 0.2.3. I'd think that the target version should be something like a FW version range accepted by the client SW, say 0.2.x in this case.

[nthdimtech]

Looks good.

The target firmware version is the latest firmware version that was available when the client was built. Later firmware versions reserve the right to new data structures that the client may not be able to read. Earlier firmware versions should work but may disable newer features in the client. I think target is a reasonable term here but maybe there is a better term or some explanation in the GUI that would be helpful.

[nthdimtech]

Here is an idea.

If the actual version is less than the target it could say something like:

"Your device firmware version is not the latest. Check 'URL' to upgrade your firmware to version X.Y.Z or higher"

If the actual version is greater than the client in at least the second to last digit (the last digit is for bug fixes) it could say something like:

"Your device firmware is newer than the client. Check 'URL' to get the latest client."

[lundacode]

Ok, thanks for he explanation, now that I understand it, "Target firmware version" makes perfect sense.

I'll might implement your idea, in the weekend, in a separate pull req.

[lundacode]

Final commit fixing compiler warnings. First the signet-base change should be merged.

[lundacode]

submodule update

[lundacode]

I think this PR is ready.

[lundacode]

ping