crypto: skip owner/signature mismatch check for objects below v2.18#3836
Merged
cthulhu-rider merged 1 commit intomasterfrom Feb 20, 2026
Merged
Conversation
End-rey
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3836 +/- ##
=======================================
Coverage 25.54% 25.55%
=======================================
Files 669 669
Lines 42943 42954 +11
=======================================
+ Hits 10970 10977 +7
- Misses 30969 30975 +6
+ Partials 1004 1002 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
End-rey
force-pushed
the
3806-owner-mismatches-signature-for-stored-objects
branch
from
3f8bcef to
be9e4da
Compare
roman-khimov
approved these changes
Feb 19, 2026
Member
roman-khimov
left a comment
roman-khimov
left a comment
There was a problem hiding this comment.
Not that I'm a fan of these checks, but we don't have many options. And once #3809 is solved we can add version restriction for PUT.
carpawell
approved these changes
Feb 19, 2026
| (v.Major() == latestSysObjTargetInPayloadMjr && v.Minor() > latestSysObjTargetInPayloadMnr) | ||
| } | ||
|
|
||
| // OwnerSignatureMatchRequired returns true if an object with the given version |
Member
There was a problem hiding this comment.
i would add some info that this was kinda error before not like a regular API change
Contributor
Author
There was a problem hiding this comment.
Clarified the comment.
End-rey
force-pushed
the
3806-owner-mismatches-signature-for-stored-objects
branch
from
be9e4da to
3603939
Compare
Member
|
Conflicts. |
End-rey
force-pushed
the
3806-owner-mismatches-signature-for-stored-objects
branch
from
29f2649 to
e875e32
Compare
Closes #3806. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
cthulhu-rider
approved these changes
Feb 20, 2026
cthulhu-rider
deleted the
3806-owner-mismatches-signature-for-stored-objects
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3806.