Merged
Conversation
Signed-off-by: Roman Khimov <roman@nspcc.ru>
v2 is obsolete and no longer supported. Signed-off-by: Roman Khimov <roman@nspcc.ru>
1.22 is obsolete. Signed-off-by: Roman Khimov <roman@nspcc.ru>
AnnaShaleva
reviewed
Feb 26, 2025
Member
AnnaShaleva
left a comment
AnnaShaleva
left a comment
There was a problem hiding this comment.
without changing the go.mod
But why?
Member
Author
|
Because it doesn't change anything really. We've done this before, if there are no real changes we can have a bit more permissive go.mod in case anyone wants to use it. |
AnnaShaleva
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I doubt we can improve anything here code-wise, so this fixes #14 without changing the go.mod, there are no changes that are applicable to this code base.