Skip to content

Semicolon#54

Open
linwaytin wants to merge 2 commits intonsmith5:masterfrom
linwaytin:semicolon
Open

Semicolon#54
linwaytin wants to merge 2 commits intonsmith5:masterfrom
linwaytin:semicolon

Conversation

@linwaytin
Copy link
Copy Markdown

@linwaytin linwaytin commented Sep 26, 2020

I make a workaround to allow ";" at the end for the issue #53 .
I also change p[i] to p[j] in the split function, which makes the results reasonable.
Thank you.

This gives the correct split function.
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 26, 2020

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 47.27%. Comparing base (7be4dbd) to head (5bf065f).

Files with missing lines Patch % Lines
src/mexpr.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   47.25%   47.27%   +0.01%     
==========================================
  Files          10       10              
  Lines         328      330       +2     
==========================================
+ Hits          155      156       +1     
- Misses        173      174       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.002%) to 46.254% when pulling 5bf065f on linwaytin:semicolon into 7be4dbd on nsmith5:master.

1 similar comment
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.002%) to 46.254% when pulling 5bf065f on linwaytin:semicolon into 7be4dbd on nsmith5:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants