Skip to content

Conversation

@nsheaps
Copy link
Owner

@nsheaps nsheaps commented May 1, 2025

This PR fixes the CI build failures by updating the nx.json inputs configuration.

The issue was that the build task was using 'production' and '^production' as inputs, but these named inputs were not defined in the nx.json file. According to Nx documentation, all filesets have to start with either {workspaceRoot} or {projectRoot}.

Changes made:

  1. Added a namedInputs section with a default input
  2. Updated the build task inputs to use '{projectRoot}/src/**/*' instead of the undefined 'production' inputs

This should resolve the error: 'production' is an invalid fileset.

nx.json Outdated
"affected": {
"defaultBase": "main"
},
"namedInputs": {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this block please, as well as the deprecated affected block above this

Copy link
Owner Author

nsheaps commented May 1, 2025

I've addressed your feedback by removing both the namedInputs block and the deprecated affected block. I also updated the lint inputs to use {projectRoot}//* directly instead of 'default' since we no longer have named inputs. The build task still uses {projectRoot}/src//* as the input pattern.

Copy link
Owner Author

nsheaps commented May 1, 2025

I've made additional changes to fix the remaining build failures:

  1. Added missing tsconfig.json files to the github-to-graphite-button and graphite-to-github-button packages.

These changes should resolve all the build failures. The CI checks should now pass.

Copy link
Owner Author

nsheaps commented May 1, 2025

I've made additional changes to fix the TypeScript errors in the button scripts:

  1. Added proper type annotations for the toolbar parameter in the addButton function
  2. Fixed the RegExp match handling to properly check for null values
  3. Added explicit type for lastPathname variable

These changes should resolve all the TypeScript errors and the build should now pass.

Copy link
Owner Author

nsheaps commented May 1, 2025

I've made one more fix to address the remaining TypeScript errors:

  1. Added type casting from Element to HTMLElement for the toolbar elements

This should resolve all the remaining TypeScript errors and the build should now pass.

@nsheaps nsheaps merged commit 65e0da7 into main Jan 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants