fix(clarify): correct question limit from 10 to 5#121
Conversation
The clarify command template was internally inconsistent: - Line 91: 'prioritized queue of candidate clarification questions (maximum 5)' - Line 92: 'Maximum of 10 total questions across the whole session' Align both to 5. The description already states 5 correctly; the 10-question cap was a copy-paste error introduced when the template was first written. Closes #59 (upstream: github#1557) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Summary of ChangesHello @nsalvacao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor but important documentation inconsistency within the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📝 AI PR SummarySummaryReduced the maximum total number of clarification questions allowed across a session from 10 to 5. Changes
Impact
🤖 Auto-generated · openai/gpt-4.1-mini · GitHub Models free tier · 0 premium requests |
🔍 AI Code ReviewReview of DiffSecurity Vulnerabilities
Bugs
Best Practice Violations
Summary: 🤖 AI Review · openai/gpt-4.1 · 440 tokens · GitHub Models free tier · 0 premium requests |
There was a problem hiding this comment.
Code Review
This pull request corrects an inconsistency in the clarify command template by changing the maximum number of questions from 10 to 5. The change is accurate and improves the document's consistency. I have provided one suggestion to further enhance clarity by removing a redundant line that results from this correction.
Summary
Fixes an internal inconsistency in the
clarifycommand template introduced when it was first written:Both should say 5. Upstream caught this in github/spec-kit#1557.
Change
1 line changed in 1 file. No code changes.
Testing
npx markdownlint-cli2 templates/commands/clarify.md— 0 errorsuv run pytest tests/ -x -q— 317 passed, 22 skippedNotes
The Gemini review on intake PR #59 noted the
(maximum 5)on line 91 becomes redundant with this fix and could be removed in a future cleanup. Kept out of scope here to keep this change minimal.Closes #59