Skip to content

fix(clarify): correct question limit from 10 to 5#121

Merged
nsalvacao merged 1 commit intomainfrom
feat/59-clarify-question-limit
Feb 19, 2026
Merged

fix(clarify): correct question limit from 10 to 5#121
nsalvacao merged 1 commit intomainfrom
feat/59-clarify-question-limit

Conversation

@nsalvacao
Copy link
Copy Markdown
Owner

Summary

Fixes an internal inconsistency in the clarify command template introduced when it was first written:

  • Line 91 says: "prioritized queue of candidate clarification questions (maximum 5)"
  • Line 92 said: "Maximum of 10 total questions across the whole session"BUG

Both should say 5. Upstream caught this in github/spec-kit#1557.

Change

-    - Maximum of 10 total questions across the whole session.
+    - Maximum of 5 total questions across the whole session.

1 line changed in 1 file. No code changes.

Testing

  • npx markdownlint-cli2 templates/commands/clarify.md — 0 errors
  • uv run pytest tests/ -x -q — 317 passed, 22 skipped

Notes

The Gemini review on intake PR #59 noted the (maximum 5) on line 91 becomes redundant with this fix and could be removed in a future cleanup. Kept out of scope here to keep this change minimal.

Closes #59

The clarify command template was internally inconsistent:
- Line 91: 'prioritized queue of candidate clarification questions (maximum 5)'
- Line 92: 'Maximum of 10 total questions across the whole session'

Align both to 5. The description already states 5 correctly; the
10-question cap was a copy-paste error introduced when the template
was first written.

Closes #59 (upstream: github#1557)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@nsalvacao nsalvacao added the bug Something isn't working label Feb 19, 2026
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @nsalvacao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor but important documentation inconsistency within the clarify command template. It ensures that the stated maximum number of clarification questions for a session is uniformly set to 5, resolving a previous discrepancy where one line indicated 10 questions. This change improves the clarity and accuracy of the template's instructions.

Highlights

  • Documentation Consistency: Corrected an internal inconsistency in the clarify command template, changing the maximum number of total questions allowed in a session from 10 to 5 to align with other parts of the template.
Changelog
  • templates/commands/clarify.md
    • Updated the maximum total questions across a session from 10 to 5 to ensure consistency within the template.
Activity
  • Performed markdownlint-cli2 on the template, resulting in 0 errors.
  • Executed pytest tests, with 317 passing and 22 skipped.
  • Noted that a Gemini review on intake PR intake: upstream #1557 (intake/lote-A-pr-1557) #59 suggested a future cleanup to remove redundant text, which was kept out of scope for this minimal change.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Copy Markdown

📝 AI PR Summary

Summary

Reduced the maximum total number of clarification questions allowed across a session from 10 to 5.

Changes

  • Updated the limit on total clarification questions from 10 to 5 in the clarify command template.

Impact

  • Limits the number of clarification questions asked during a session, potentially making interactions more concise and focused.

🤖 Auto-generated · openai/gpt-4.1-mini · GitHub Models free tier · 0 premium requests

@github-actions
Copy link
Copy Markdown

🔍 AI Code Review

Review of Diff

Security Vulnerabilities

  • 🔵 Info: No code changes, only markdown/template update. No security vulnerabilities introduced.

Bugs

  • 🔵 Info: No functional code changes, so no bugs introduced.

Best Practice Violations

  • 🟡 Warning: The reduction from "maximum of 10 total questions" to "maximum of 5 total questions" across the session could impact the effectiveness of the clarification process. If the session requires more clarifications, this constraint may limit the ability to resolve ambiguities, potentially affecting user experience or outcome quality. Ensure this change aligns with intended workflow and user needs.

Summary:
No security or bug issues. The change is a best practice concern regarding usability and effectiveness. Review the rationale for reducing the question limit to ensure it does not hinder the process.


🤖 AI Review · openai/gpt-4.1 · 440 tokens · GitHub Models free tier · 0 premium requests

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects an inconsistency in the clarify command template by changing the maximum number of questions from 10 to 5. The change is accurate and improves the document's consistency. I have provided one suggestion to further enhance clarity by removing a redundant line that results from this correction.

Comment thread templates/commands/clarify.md
@nsalvacao nsalvacao merged commit f461725 into main Feb 19, 2026
7 checks passed
@nsalvacao nsalvacao deleted the feat/59-clarify-question-limit branch February 19, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant