fix(nx-cloud): allow download-cloud-client to work outside nx workspaces#34746
Merged
fix(nx-cloud): allow download-cloud-client to work outside nx workspaces#34746
Conversation
Remove the isNxCloudUsed guard that prevented the command from running without an nx.json. Now gracefully falls back to default cloud URL when not in an Nx workspace. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit a1e500d
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
approved these changes
Mar 6, 2026
Contributor
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@22.6.0-pr.34746.a1e500d my-workspaceOr just copy this version and use it in your own command: 22.6.0-pr.34746.a1e500d
To request a new release for this pull request, mention someone from the Nx team or the |
MaxKless
added a commit
that referenced
this pull request
Mar 11, 2026
The isNxCloudCommand guard in nx.ts was missing download-cloud-client, preventing it from running outside an Nx workspace despite #34746 fixing the handler itself. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the isNxCloudUsed guard that prevented the command from running without an nx.json. Now gracefully falls back to default cloud URL when not in an Nx workspace.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #