fix(testing): handle undefined options in playwright e2e preset#34741
Open
yjaaidi wants to merge 2 commits intonrwl:masterfrom
Open
fix(testing): handle undefined options in playwright e2e preset#34741yjaaidi wants to merge 2 commits intonrwl:masterfrom
yjaaidi wants to merge 2 commits intonrwl:masterfrom
Conversation
✅ Deploy Preview for nx-docs canceled.
|
✅ Deploy Preview for nx-dev canceled.
|
yjaaidi
added a commit
to marmicode/pragmatic-angular-testing
that referenced
this pull request
Mar 6, 2026
yjaaidi
added a commit
to marmicode/pragmatic-angular-testing
that referenced
this pull request
Mar 6, 2026
* build: 📦 upgrade swc-angular to avoid nx crash... ...when loading jest with incompatible swc version during nx migration * build: 📦 nx migrate latest * build: 📦 remove migrations.json Made-with: Cursor * build: 📦 update vitest to 4.0.18 * ci: 🤖 upgrade github actions * test: ✅ fix testronaut config cf. nrwl/nx#34741
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling Playwright's
nxE2EPreset(__filename)(without options) fails.P.S.: I just stumbled upon #34302 & #34301
I guess it's better if we let Playwright handle the default value for
openHtmlReport