fix(core): improve nx wrapper error message for malformed nx.json#34736
Merged
FrozenPandaz merged 2 commits intomasterfrom Mar 10, 2026
Merged
fix(core): improve nx wrapper error message for malformed nx.json#34736FrozenPandaz merged 2 commits intomasterfrom
FrozenPandaz merged 2 commits intomasterfrom
Conversation
When nx.json exists but contains a syntax error, the nx wrapper now shows the actual parse error instead of the misleading message that nx.json is missing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 95dd58b
☁️ Nx Cloud last updated this comment at |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
FrozenPandaz
requested changes
Mar 6, 2026
Move the missing-file vs parse-error distinction into the catch block by checking the error code instead of using a separate existsSync call. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
FrozenPandaz
approved these changes
Mar 10, 2026
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
When
nx.jsonexists but contains a syntax error (e.g. invalid JSON), the nx wrapper shows:This is misleading because the file exists — it's just malformed.
Expected Behavior
The nx wrapper now distinguishes between a missing
nx.jsonand a malformed one:[NX]: The "nx.json" file is required when running the nx wrapper.[NX]: Failed to parse "nx.json": <actual error>. See ...The existence check is done upfront before attempting to parse, so the
catchblock only handles parse errors.