Skip to content

fix(nx-dev): cross site link checks working as expected#34685

Merged
barbados-clemens merged 5 commits intomasterfrom
cu/DOC-424-linking-time
Mar 17, 2026
Merged

fix(nx-dev): cross site link checks working as expected#34685
barbados-clemens merged 5 commits intomasterfrom
cu/DOC-424-linking-time

Conversation

@barbados-clemens
Copy link
Copy Markdown
Contributor

No description provided.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 3, 2026

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 92f6ec9
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/69b87b78232a530008828a59
😎 Deploy Preview https://deploy-preview-34685--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 3, 2026

Deploy Preview for nx-dev ready!

Name Link
🔨 Latest commit 92f6ec9
🔍 Latest deploy log https://app.netlify.com/projects/nx-dev/deploys/69b87b78edb9c100086bf600
😎 Deploy Preview https://deploy-preview-34685--nx-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Mar 3, 2026

View your CI Pipeline Execution ↗ for commit 92f6ec9

Command Status Duration Result
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 3m 55s View ↗
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 2m 36s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 8s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-16 22:02:07 UTC

@barbados-clemens barbados-clemens force-pushed the cu/DOC-424-linking-time branch 2 times, most recently from 00461f4 to 4b6f2be Compare March 4, 2026 00:01
Comment thread astro-docs/validate-links.ts
nx-cloud[bot]

This comment was marked as outdated.

@barbados-clemens barbados-clemens self-assigned this Mar 5, 2026
@barbados-clemens barbados-clemens force-pushed the cu/DOC-424-linking-time branch from 8aee18f to dca7963 Compare March 10, 2026 20:34
nx-cloud[bot]

This comment was marked as outdated.

@barbados-clemens barbados-clemens force-pushed the cu/DOC-424-linking-time branch from 670f622 to 422793b Compare March 13, 2026 14:48
nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

barbados-clemens and others added 4 commits March 16, 2026 16:21
- Break docs/ → astro link (reference-style): /docs/guides/adopting-nx/import-project-BROKEN-TEST
- Break astro → nx-dev link: /blog/setup-tailwind-4-angular-nx-workspace-BROKEN-TEST

This commit should fail validate-links in CI. Revert after confirming.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: barbados-clemens <barbados-clemens@users.noreply.github.com>
@barbados-clemens barbados-clemens force-pushed the cu/DOC-424-linking-time branch from 849006f to 011eae4 Compare March 16, 2026 21:21
Copy link
Copy Markdown
Contributor

@nx-cloud nx-cloud Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ The fix from Nx Cloud was applied

We updated the broken /docs/nx-api/devkit link in nx-vs-turborepo.mdoc to /docs/extending-nx/intro, which resolves the astro-docs:validate-links failure. This link was previously masked by the /nx-api/ entry in the ignoredLinks list, which this PR intentionally removed to enforce stricter validation.

Tip

We verified this fix by re-running astro-docs:validate-links.

Suggested Fix changes
diff --git a/astro-docs/src/content/docs/guides/Adopting Nx/nx-vs-turborepo.mdoc b/astro-docs/src/content/docs/guides/Adopting Nx/nx-vs-turborepo.mdoc
index c3b549c7b5..9193fc6665 100644
--- a/astro-docs/src/content/docs/guides/Adopting Nx/nx-vs-turborepo.mdoc	
+++ b/astro-docs/src/content/docs/guides/Adopting Nx/nx-vs-turborepo.mdoc	
@@ -225,7 +225,7 @@ Both tools offer code generation, but the depth differs significantly.
 
 Turborepo provides `turbo gen`, a thin wrapper around [Plop.js](https://plopjs.com/). It can scaffold new workspaces and create files from Handlebars templates, but it's limited to template-based file creation and simple string append/prepend operations. There's no AST-level code modification, no awareness of the project graph, and no migration/codemod system.
 
-Nx generators are built on top of [Nx Devkit](/docs/nx-api/devkit), a full programmatic API for workspace manipulation. Generators can read and modify the project graph, perform AST-level TypeScript transforms, and compose with other generators. You can create [local workspace generators](/docs/features/generate-code#creating-custom-generators) that encode your team's specific patterns.
+Nx generators are built on top of [Nx Devkit](/docs/extending-nx/intro), a full programmatic API for workspace manipulation. Generators can read and modify the project graph, perform AST-level TypeScript transforms, and compose with other generators. You can create [local workspace generators](/docs/features/generate-code#creating-custom-generators) that encode your team's specific patterns.
 
 The real value isn't raw scaffolding, AI can do that too. It's deterministic, convention-aware generation. **AI agents can invoke your generators to produce code matching your patterns from the start.** This is faster and more token-efficient than generating everything from scratch.
 

Note

Auto-apply was skipped. The previous CI pipeline execution was triggered by Nx Cloud

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.

Revert fix via Nx Cloud  

View interactive diff ↗

🎓 Learn more about Self-Healing CI on nx.dev

Co-authored-by: barbados-clemens <barbados-clemens@users.noreply.github.com>
@barbados-clemens barbados-clemens merged commit d6f22a2 into master Mar 17, 2026
24 checks passed
@barbados-clemens barbados-clemens deleted the cu/DOC-424-linking-time branch March 17, 2026 20:55
FrozenPandaz pushed a commit that referenced this pull request Mar 20, 2026
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
Co-authored-by: barbados-clemens <barbados-clemens@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants