fix(nx-plugin): include overrides in generated package-lock.json#34666
Closed
christopher-drifte wants to merge 2 commits intonrwl:masterfrom
Closed
fix(nx-plugin): include overrides in generated package-lock.json#34666christopher-drifte wants to merge 2 commits intonrwl:masterfrom
christopher-drifte wants to merge 2 commits intonrwl:masterfrom
Conversation
✅ Deploy Preview for nx-docs canceled.
|
✅ Deploy Preview for nx-dev canceled.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
The seenPackages Set was initialized once at the function level and shared across all overridden packages. This caused transitive dependencies to be incorrectly skipped when multiple overridden packages shared common dependencies.
Author
|
Fixed by #35192 |
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
When using Nx to generate a pruned
package-lock.jsonwith npm overrides defined in the rootpackage.json, the override packages and their transitive dependencies are not included in the generated lockfile. This causes npm install to fail in the pruned context.Minimum reproduction: https://github.com/chrisdrifte/minimatch-override-repro
Expected Behavior
The generated
package-lock.jsonshould include all packages specified in npm overrides (frompackage.json#overrides), along with their transitive dependencies, ensuring successful npm installs.Documentation: https://docs.npmjs.com/cli/v11/configuring-npm/package-json#overrides
Related Issue(s)
Fixes #34529