Open
Conversation
Extended Console::select to define if you want the function to return the key or the value of the array.
If nothing is entered, the function asks again.
Owner
|
Hi, this is a good addition. A couple of things need to be addressed before I can merge this in: First: On line 364, you have the following code: What if one of the input options is 0? 0 or '0' in PHP are considered to be false-y values. I think this bit is unnecessary. Second: There seems to be a mix of spaces and tabs. If you could change the indentations to just 4 spaces and have the closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended Console::select to define if you want the function to return the key or the value of the array.
Please consider a review and merge ;-)