Skip to content

Update Console.php#4

Open
kakohari wants to merge 2 commits intonramenta:masterfrom
kakohari:master
Open

Update Console.php#4
kakohari wants to merge 2 commits intonramenta:masterfrom
kakohari:master

Conversation

@kakohari
Copy link
Copy Markdown

Extended Console::select to define if you want the function to return the key or the value of the array.
Please consider a review and merge ;-)

Extended Console::select to define if you want the function to return the key or the value of the array.
If nothing is entered, the function asks again.
@nramenta
Copy link
Copy Markdown
Owner

Hi, this is a good addition. A couple of things need to be addressed before I can merge this in:

First: On line 364, you have the following code:

if (!$input) {goto top;}

What if one of the input options is 0? 0 or '0' in PHP are considered to be false-y values. I think this bit is unnecessary.

Second: There seems to be a mix of spaces and tabs. If you could change the indentations to just 4 spaces and have the closing } and elseif on lines 375 and 376 be on the same line, that would be great.

@nramenta nramenta closed this Oct 25, 2014
@nramenta nramenta reopened this Oct 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants