Skip to content

feat: add Serbian Latin (sr-Latn-RS) localization#2317

Open
miljkovic5 wants to merge 3 commits intonpmx-dev:mainfrom
miljkovic5:feature/serbian-translation
Open

feat: add Serbian Latin (sr-Latn-RS) localization#2317
miljkovic5 wants to merge 3 commits intonpmx-dev:mainfrom
miljkovic5:feature/serbian-translation

Conversation

@miljkovic5
Copy link
Copy Markdown

🔗 Linked issue

/

🧭 Context

Adds a full Serbian (Latin script) translation for sr-Latn-RS.
All 1522 translation keys are covered.

📚 Description

This PR adds a complete Serbian (Latin) translation for the sr-Latn-RS locale.

What's included

  • Full translation of all UI strings, error messages, SEO metadata,
    accessibility labels, blog, settings, package pages, compare, and legal pages
  • Correct 3-form plurals for all applicable keys
  • Serbian pangram for the typography preview:
    "Ljubazni fenjerdžija čađavog lica hoće da mi pokaže štos."

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 29, 2026 8:40pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 29, 2026 8:40pm
npmx-lunaria Ignored Ignored Mar 29, 2026 8:40pm

Request Review

@github-actions
Copy link
Copy Markdown

Hello! Thank you for opening your first PR to npmx, @miljkovic5! 🚀

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@miljkovic5 miljkovic5 changed the title feat: Add Serbian Latin (sr-Latn-RS) localization feat: add Serbian Latin (sr-Latn-RS) localization Mar 29, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8af8f228-d65d-4edc-87bb-14e80b8be2f6

📥 Commits

Reviewing files that changed from the base of the PR and between 3eb3798 and e791066.

📒 Files selected for processing (1)
  • i18n/locales/sr-Latn-RS.json

📝 Walkthrough

Walkthrough

This pull request adds support for Serbian (Latin, RS) by registering a new locale sr-Latn-RS in config/i18n.ts with a custom plural rule and by adding a full translation catalogue at i18n/locales/sr-Latn-RS.json (≈1521 lines) covering the app UI, domain pages, messages, and pluralised/parameterised strings.

Possibly related PRs

Suggested reviewers

  • danielroe
  • ghostdevv
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description accurately describes the changeset, detailing the addition of a complete Serbian (Latin) translation covering all 1,522 translation keys, including UI strings, error messages, pluralization rules, and a Serbian pangram.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0fbabdcb-22ed-4590-a086-9707dfec43d3

📥 Commits

Reviewing files that changed from the base of the PR and between e2a7b59 and 3eb3798.

📒 Files selected for processing (2)
  • config/i18n.ts
  • i18n/locales/sr-Latn-RS.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant