Skip to content

Conversation

@jonathanyeong
Copy link
Contributor

@jonathanyeong jonathanyeong commented Feb 10, 2026

This will skip running this github action on forks which will always fail (example).

I think it's okay to limit to github repository since the tangled remote is also hardcoded to npmx:

          git remote add tangled git@tangled.org:npmx.dev/npmx.dev

Github actions doc: https://docs.github.com/en/actions/how-tos/write-workflows/choose-when-workflows-run/control-jobs-with-conditions

@vercel
Copy link

vercel bot commented Feb 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 10, 2026 8:07pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 10, 2026 8:07pm
npmx-lunaria Ignored Ignored Feb 10, 2026 8:07pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2026

📝 Walkthrough

Walkthrough

This pull request modifies the .github/workflows/mirror-tangled.yml workflow to add a conditional guard to the mirror job. The condition restricts the job so it runs only when the repository is npmx-dev/npmx.dev. No other workflow logic or steps were changed. The change adds one line to the file.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains the purpose of limiting the GitHub Action to the npmx repository to prevent failures on forks, with supporting rationale and documentation links.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@jonathanyeong jonathanyeong changed the title feat: only run mirror to tangled on npmx repo ci: only run mirror to tangled on npmx repo Feb 10, 2026
This will skip running this github action on forks which will always fail.
@danielroe danielroe enabled auto-merge February 10, 2026 20:07
@danielroe danielroe added this pull request to the merge queue Feb 10, 2026
Merged via the queue into npmx-dev:main with commit 531443f Feb 10, 2026
18 checks passed
@jonathanyeong
Copy link
Contributor Author

Confirmed job skipped on my fork https://github.com/jonathanyeong/npmx.dev/actions/runs/21881062641

@jonathanyeong jonathanyeong deleted the feat/limit-tangled-mirror branch February 10, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants