Skip to content

feat(ui): generalize downloads chart and add social likes option #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
serhalp wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(ui): generalize downloads chart and add social likes option #1310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62e85e4
feat: add social likes facet to package trends charts
serhalp Feb 6, 2026
52247b4
fix: remove dup key in fr-FR.json from bad rebase
serhalp Feb 10, 2026
b4ddfea
fix(i18n): remove outdated compare.trends.title translations
serhalp Feb 10, 2026
f7af4cc
[autofix.ci] apply automated fixes
autofix-ci[bot] Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/components/Compare/LineChart.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script setup lang="ts">
import DownloadAnalytics from '../Package/DownloadAnalytics.vue'
import TrendsChart from '../Package/TrendsChart.vue'

const { packages } = defineProps<{
packages: string[]
Expand All @@ -8,6 +8,6 @@ const { packages } = defineProps<{

<template>
<div class="font-mono">
<DownloadAnalytics :package-names="packages" :in-modal="false" />
<TrendsChart :package-names="packages" :in-modal="false" show-facet-selector />
</div>
</template>
8 changes: 6 additions & 2 deletions app/components/Package/ChartModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
<script setup lang="ts"></script>
<script setup lang="ts">
defineProps<{
modalTitle?: string
}>()
</script>

<template>
<Modal
:modalTitle="$t('package.downloads.modal_title')"
:modalTitle="modalTitle ?? $t('package.trends.title')"
id="chart-modal"
class="h-full sm:h-min sm:border sm:border-border sm:rounded-lg shadow-xl sm:max-h-[90vh] sm:max-w-3xl"
>
Expand Down
Loading
Loading