-
-
Notifications
You must be signed in to change notification settings - Fork 232
fix: allow all heading depths in readme and transform them #1306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Unfortunately, the renderer will have to be rewritten, since we need to loop through both the HTML and MD from file in a single loop to ensure complete correctness. Otherwise, we can't guarantee the order in which headers are extracted and slugs are generated (especially with repeated content). I didn't touch this here, since it would likely rewrite half the file. I'll create a new issue tomorrow |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThis PR modifies the README sanitisation logic in Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Headings were getting lost in the readme. They were getting lost because we weren't processing them. That is, if a user added h1 or h2 via HTML, they weren't processed.
I added processing to them and all other levels that weren't processed via Markdown so that the correct style would be applied.
Closes #1093