feat: add PWA web manifest (without service worker) #1181
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
| '/manifest.webmanifest': { | ||
| headers: { | ||
| 'Content-Type': 'application/manifest+json', | ||
| 'Cache-Control': 'public, max-age=0, must-revalidate', |
There was a problem hiding this comment.
Why not some minimal caching, e.g.:
| 'Cache-Control': 'public, max-age=0, must-revalidate', | |
| 'Cache-Control': 'public, max-age=3600', |
?
There was a problem hiding this comment.
The webmanifest should be always checked like the service worker. Once web manifest stable we can change the cache control header.
There was a problem hiding this comment.
There is a problem with the icon, it is square, but on other shapes of icons (for example, round ones), the edges are white, this needs to be fixed.
It would also be great to add a monochrome version of the icon to have this icon themed as well.
There was a problem hiding this comment.
We need to change the svg icons again, will be fixed once the service worker fixed (search page)
3 participants
I need to resolve a permanent redirection when requesting the webmanifest on local dev server or build + preview, works in the preview.
@danielroe wants to add the service worker, we'll need to:
NOTE: open pr preview in private browsing
resolves #1124