-
-
Notifications
You must be signed in to change notification settings - Fork 232
feat: tweak button & link styles #1163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jellydeck
wants to merge
27
commits into
npmx-dev:main
Choose a base branch
from
jellydeck:button-butter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
c76cc87
buttons & links style adjusted
jellydeck 9b7add1
some cleanup
jellydeck 881330f
few more tweaks 😌
jellydeck 558bcad
fix: rounded on focus-visible
jellydeck 5bc5e5a
for thasmo 🫡
jellydeck 8fedbdd
class as props
jellydeck 1a85202
on active scale down for feedback
jellydeck dd19dda
border for secondary buttons
jellydeck af5b977
missing & clipping outlines
jellydeck 49195a6
outlines in compare, readme, settings
jellydeck faabc73
remove class from props
jellydeck 67858b5
upstream changes for button
jellydeck 2442382
global css cleanup
jellydeck f4e0178
Merge branch 'main' into button-butter
jellydeck 5488d39
fix: homepage layout shift
jellydeck f0443a0
removed redundant class
jellydeck 1ae70e7
Merge branch 'main' into button-butter
jellydeck 5e64320
Merge branch 'main' into button-butter
jellydeck dc2f1e0
Merge branch 'main' into button-butter
jellydeck 469ec33
Merge branch 'main' into button-butter
jellydeck aa3d772
fixes as per suggestions
jellydeck dc748ed
styling fixes
jellydeck d0dd0ed
Merge branch 'main' into button-butter
jellydeck 3c00392
use directional class
jellydeck 5ccfa5c
Merge branch 'button-butter' of https://github.com/jellydeck/npmx.dev…
jellydeck e9b9527
fix: build issues
jellydeck 837c94b
remove borders from AppHeader
jellydeck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,8 @@ | ||
| <template> | ||
| <div class="relative flex min-w-28 justify-end"> | ||
| <div | ||
| class="inline-flex gap-x-1 items-center justify-center font-mono border border-border rounded-md text-sm px-4 py-2 bg-transparent text-fg border-none" | ||
| > | ||
| <span class="font-mono text-sm text-fg-muted">{{ $t('account_menu.connect') }}</span> | ||
| <span class="i-carbon-chevron-down w-3 h-3 text-fg-muted" aria-hidden="true" /> | ||
| </div> | ||
| <div | ||
| class="inline-flex gap-x-1.5 items-center justify-center font-mono rounded-md text-sm px-4 py-2 bg-transparent text-fg" | ||
| > | ||
| <span class="font-sans text-sm text-fg-muted">{{ $t('account_menu.connect') }}</span> | ||
| <span class="i-carbon-chevron-down w-3 h-3 text-fg-muted" aria-hidden="true" /> | ||
| </div> | ||
| </template> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -109,7 +109,8 @@ defineExpose({ focus }) | |
| <div class="relative group" :class="{ 'is-focused': isSearchFocused }"> | ||
| <div class="search-box relative flex items-center"> | ||
| <span | ||
| class="absolute inset-is-3 text-fg-subtle font-mono text-sm pointer-events-none transition-colors duration-200 motion-reduce:transition-none [.group:hover:not(:focus-within)_&]:text-fg/80 group-focus-within:text-accent z-1" | ||
| aria-hidden="true" | ||
| class="absolute inset-is-3 text-fg-subtle font-mono text-sm pointer-events-none transition-colors duration-200 motion-reduce:transition-none group-focus-within:text-accent z-1" | ||
| > | ||
| / | ||
| </span> | ||
|
|
@@ -127,7 +128,7 @@ defineExpose({ focus }) | |
| @blur="isSearchFocused = false" | ||
| size="small" | ||
| /> | ||
| <button type="submit" class="sr-only">{{ $t('search.button') }}</button> | ||
| <button type="submit" class="sr-only" tabindex="-1">{{ $t('search.button') }}</button> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure what the consequences are of adding |
||
| </div> | ||
| </div> | ||
| </form> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add outline-offset to prevent clipped focus rings in Firefox.
Line 225 sets
outline: autofor:-moz-focusringwithout an offset; in tight or overflow-clipped layouts this can hide the ring (a reported issue in this PR). Adding an offset keeps the focus indicator visible.Suggested fix
:-moz-focusring { outline: auto; + outline-offset: 2px; }📝 Committable suggestion