Skip to content
This repository was archived by the owner on Nov 16, 2019. It is now read-only.

always include main file, even if not configured#19

Open
zkat wants to merge 1 commit intomasterfrom
zkat/include-default-main
Open

always include main file, even if not configured#19
zkat wants to merge 1 commit intomasterfrom
zkat/include-default-main

Conversation

@zkat
Copy link
Contributor

@zkat zkat commented Mar 17, 2016

Fixes: npm/npm#8510

@jasonkarns
Copy link

Does it make sense for this to be hardcoded? This bit of knowledge (ie, the default main filename) ideally shouldn't be duplicated anywhere. And the logic for normalizing the package.json into an object with defaults and various formattings already exists in https://github.com/npm/read-package-json

I would expect that fstream instead just read from the normalized package.json to be consistent?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants