docs: clarify versioned override parent behavior#9537
Conversation
|
Nice clarification, and the core point checks out. I confirmed in the arborist code and with a real install that a versioned key like |
|
Implemented the scoped override follow-up in docs: added explicit note that / are unscoped and do not match scoped packages, and kept the examples using full scoped refs (, ) in . Please re-review when convenient. |
|
Implemented the scoped override follow-up in docs: clarified that and are unscoped references and kept the examples using full scoped references (npm/foo, npm/bar) in package-json docs. |
|
Implemented the follow-up request on the override examples. The parent-key example now explicitly uses , and the direct dependency reference examples now show both unscoped-invalid and scoped-correct forms (/ vs /). Please feel free to re-review. |
|
Implemented the follow-up request on the |
|
Thanks for the catch on scoped references. I just pushed 4dfff94 with a docs clarification that explicitly states scoped overrides must use the full scoped name (e.g. ) and kept the bad/good examples aligned; please re-review this patch when convenient. |
|
If this still misses your expectation for the follow-up, please share the exact line-level mismatch and I will adjust immediately. |
owlstronaut
left a comment
There was a problem hiding this comment.
Thanks, the new ".": "$@npm/bar" example and the "@npm/foo": "$@npm/foo" fix both look right, and I confirmed they resolve in a real install. One thing got over-corrected though: "@npm/bar": "$@npm/bar" no longer matches its own comment just above it ("the referenced package does not need to match the overridden one"). That line was originally "$foo" on purpose, to show you can reference one package's spec ( @npm/foo , a real direct dependency) and apply it to a different override key ( @npm/bar ). Since @npm/bar isn't a direct dependency here, $@npm/bar doesn't actually reference a direct dep the way the surrounding text describes. I think you want "@npm/bar": "$@npm/foo" to keep that example intact. Also minor, but the added comment block is a bit repetitive now that the prose above already explains the scoped-name rule, so you could probably trim it down.
|
I pushed commit b574dac to address the remaining scoped-reference mismatch ( now reuses to keep the example consistent with the direct-dependency rule). Please re-review when convenient. |
|
The remaining requested scoped-override example is now on branch as |
|
I just pushed commit 15f02a8 with a small follow-up doc clarification for the scoped override example ( now explicitly uses under the note that reference and override target can differ), per your requested alignment. Please re-review when convenient. |
|
I pushed commit 15f02a8 with a docs follow-up for the scoped |
|
I added one more documentation clarifying follow-up to the scoped override example ( can intentionally reference ). Commit: d49e687. Please re-review when convenient. |
|
I added another follow-up clarification in commit |
|
Implemented the remaining scoped override follow-up in commit c5088fb by tightening the note text and removing the extra line so the example stays concise. Please re-review when convenient. |
|
I kept the scoped override follow-up scoped down and landed a cleanup in commit 65a5b62: replaced the redundant scoped-reference sentence in so the section stays explicit without repetition while keeping and alignment unchanged. |
|
Implemented the scoped override follow-up in commit c63c1f5. The scoped |
Summary
"."while only overriding childrenTesting
node ./scripts/resetdeps.jsis required before broader checks can run)