Skip to content

Fix the StreamInfo and MediaInfo clone #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bertonwalker-cn wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix the StreamInfo and MediaInfo clone #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94cf7fe
Fix MediaInfo lost Protocal and Payloads in Clone func
Sep 13, 2024
97d6d10
Fix StreamInfo.Clone() makes panic
Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mediainfo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ func (m *MediaInfo) Clone() *MediaInfo {
if m.simulcast {
cloned.SetSimulcast(m.simulcast)
}
cloned.Protocal = m.Protocal
cloned.Payloads = m.Payloads
return cloned
}

Expand Down
20 changes: 10 additions & 10 deletions streaminfo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ func (s *StreamInfo) Clone() *StreamInfo {
tracks: make([]*TrackInfo, 0),
}

for k, v := range s.tracks {
stream.tracks[k] = v.Clone()
for _, v := range s.tracks {
stream.tracks = append(stream.tracks, v.Clone())
}
return stream
}
Expand All @@ -40,20 +40,20 @@ func (s *StreamInfo) AddTrack(track *TrackInfo) {
}

func (s *StreamInfo) RemoveTrack(track *TrackInfo) {
tracks := make([]*TrackInfo,0)
for _,temtrack := range s.tracks {
tracks := make([]*TrackInfo, 0)
for _, temtrack := range s.tracks {
if temtrack.GetID() != track.GetID() {
tracks = append(tracks,temtrack)
tracks = append(tracks, temtrack)
}
}
s.tracks = tracks
}

func (s *StreamInfo) RemoveTrackById(trackId string) {
tracks := make([]*TrackInfo,0)
for _,temtrack := range s.tracks {
tracks := make([]*TrackInfo, 0)
for _, temtrack := range s.tracks {
if temtrack.GetID() != trackId {
tracks = append(tracks,temtrack)
tracks = append(tracks, temtrack)
}
}
s.tracks = tracks
Expand All @@ -77,12 +77,12 @@ func (s *StreamInfo) GetTracks() []*TrackInfo {

func (s *StreamInfo) RemoveAllTracks() {

s.tracks = make([]*TrackInfo,0)
s.tracks = make([]*TrackInfo, 0)
}

func (s *StreamInfo) GetTrack(trackID string) *TrackInfo {

for _,track := range s.tracks {
for _, track := range s.tracks {
if track.GetID() == trackID {
return track
}
Expand Down